Update operations.html #2879
Closed
Update operations.html #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Pipe characters dropped from Fact during Parsing mitre#2877
|
@neptunia @bjeffries Ive patched this issue for v5 (mitre/magma#41) . Do you need it for v4 as well? TLDR - was attempting to put in a PR against v.4.2 but now hitting other issues so just making sure that the change would be useful in v4 as well before I keep going. |
|
Closing as patch was made in v5, reopen if problem persists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Pipe characters dropped from Fact during Parsing #2877
Description
Fixes an issue with facts containing the pipe character |, so that they are no longer dropped. Instead of using a separator value to delimit the fact name and value, prepend and store the length of the fact name, then extract the name and value using that.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Ran the modified code with links with associated facts. Some facts contained the pipe character and some did not.
Checklist: