Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch recommonmark to MyST-Parser #2641

Merged
merged 4 commits into from
Aug 19, 2022

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Aug 15, 2022

Description

Recommonmark is what we use to parse our markdown documentation for Sphinx, but it is no longer maintained. The recommendation is to use MyST-Parser instead. This PR should only be merged in tandem with mitre/fieldmanual#104.

MyST-Parser is very noisy with --log-level DEBUG, so I set it to only emit warnings and errors.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Built the docs after the changes, verified that pages still displayed correctly and links work, and that extraneous debug messages are not emitted with --log-level DEBUG.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@clenk clenk requested a review from elegantmoose as a code owner August 15, 2022 00:58
@elegantmoose
Copy link
Contributor

elegantmoose commented Aug 18, 2022

@clenk Do you want to re-pin fieldmanual on this PR then too? (merged the fieldmanual PR)

@clenk
Copy link
Contributor Author

clenk commented Aug 19, 2022

@elegantmoose yes, done.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elegantmoose elegantmoose merged commit 695895b into master Aug 19, 2022
@elegantmoose elegantmoose deleted the clenk/virts-2948/docs-myst-parser branch August 19, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants