Allow call args of arbitrary type #953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesob
force-pushed
the
jamesob-22-01-unpickling
branch
from
643fc4c
to
33320af
Compare
jamesob
added a commit
to chaincodelabs/bmon
that referenced
this pull request
Aug 11, 2022
jamesob
force-pushed
the
jamesob-22-01-unpickling
branch
2 times, most recently
from
6980192
to
79a5052
Compare
End users can now control which types can be unpickled using `Connection.pickle_whitelist_patterns`, which allows remote function call arguments of any type to be used.
jamesob
force-pushed
the
jamesob-22-01-unpickling
branch
from
79a5052
to
5759a1d
Compare
|
Is this project not maintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #894.
This change allows end-users to specify allowable globals for unpickling, which is done to allow
CALL_FUNCTIONarguments to be of potentially arbitrary type. I think there's very high convenience here, since it's nice to be able to pass user-defined objects to children as call arguments to encapsulate, for example, complex configuration parameters.This change also adds default deserialization capabilities for
types.SimpleNamespace(in Python 3), since this is another handy and safe container for task arguments.If there's conceptual interest here, I can add some tests.