Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the docker/compose setup #3802

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhysyngsun
Copy link
Contributor

Pre-Flight checklist

  • Testing
    • Changes have been manually tested

What are the relevant tickets?

N/A

What's this PR do?

I'd like to try out some features in newer elasticsearch/opensearch, but before I do that I'd like to have a cleaner foundation to work on with docker - this cleans up the configuration to be in line with how mitx online is setup by using compose profiles and multistage docker builds.

How should this be manually tested?

You should be able to run docker-compose up as normal and not have the notebook container start. Running docker-compose --profile notebook up should give you the notebook.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #3802 (b775f93) into master (8f1535e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3802      +/-   ##
==========================================
- Coverage   87.30%   87.29%   -0.02%     
==========================================
  Files         336      336              
  Lines       13921    13921              
  Branches     1709     1709              
==========================================
- Hits        12154    12152       -2     
- Misses       1507     1508       +1     
- Partials      260      261       +1     
Impacted Files Coverage Δ
search/api.py 95.93% <0.00%> (-1.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mbertrand mbertrand self-assigned this Jan 11, 2023
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting 404's on this branch for the following:

http://od.odl.local:8062/style.js
http://od.odl.local:8062/root.js

After switching back to the master branch and rebuilding, the files were available.

Switched back to this branch again, rebuilt, and the files are missing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants