config: add external course sync api key in xpro #2846
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arslanashraf7
requested changes
Dec 12, 2024
| @@ -324,6 +324,7 @@ | |||
| "ENROLLMENT_CHANGE_SHEET_ID": xpro_vault_secrets["google-sheets"][ | |||
| "enroll_change_sheet_id" | |||
| ], | |||
| "EXTERNAL_COURSE_SYNC_API_KEY": xpro_vault_secrets["emeritus"]["api_key"], | |||
There was a problem hiding this comment.
We should not use the emeritus key map for this as we are going to remove that in future and generalize the key for all external course syncs. we should instead use "EXTERNAL_COURSE_SYNC_API_KEY": xpro_vault_secrets["external-course-sync"]["api_key"]
I think this should be done on the same pattern as #2512. So, Someone from the @mitodl/devops will need to add additional commits to this to pull the value from the vault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/6107
Description (What does it do?)
This PR adds
EXTERNAL_COURSE_SYNC_API_KEYto xpro envScreenshots (if appropriate):
How can this be tested?
Additional Context