-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Md/unifed ecomm #2828
Merged
Merged
Md/unifed ecomm #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and publishing them.
for more information, see https://pre-commit.ci
Ardiea
requested review from
feoh,
jkachel,
blarghmatey and
ChristopherChudzicki
December 6, 2024 18:14
jkachel
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. I have a question noted about the changes to the API client build pipeline, and one more:
For clarity - we'll have a separate branch for production deploy that we'll coordinate releases to via doof?
…cert to every cluster.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/6201
Description (What does it do?)
release
andrelease-candidate
branches.gateway configuration, and APISIX resources for running the backend.api.pay-ci.ol.mit.edu
api-pay-ci.ol.mit.edu
route53 entry.cert-manager
becausecert-manager
doesn't have full support for apisix custom resources. It is always somethin'.TODO after this is merged