Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add vat id in hubspot properties sync #2851

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

arslanashraf7
Copy link
Contributor

@arslanashraf7 arslanashraf7 commented Jan 5, 2024

Pre-Flight checklist

  • Testing
    • Code is tested
    • Changes have been manually tested

What are the relevant tickets?

#2847

What's this PR do?

  • Adds the VAT ID property in HubSpot properties sync command
  • Fixes sync issues with choice group order

How should this be manually tested?

  • Setup a test account on HubSpot
  • Add a private app in integrations (settings->Integrations->Private Apps)
  • Copy the access token secret and place it as a value for MITOL_HUBSPOT_API_PRIVATE_TOKEN
  • Copy the client secret and place it as a value for HUBSPOT_PIPELINE_ID
  • I would suggest reproducing this issue on master first:
    • Run ./manage.py configure_hubspot_properties once above configs are done
    • Notice error about duplicate orders in field choices of deal
    • Create a new user and also notice that you see 400 errors from sync_contact_with_hubspot
  • Shift to this branch, And run ./manage.py configure_hubspot_properties again an this should succeed now
  • Now manually trigger sync_contact_with_hubspot(<user_id>) and this should succeed
  • Check that you see this user in Contacts on HubSpot
  • Check that the user represents the VAT ID correctly on Hubspot contact properties

If you have any confusion, Please ping me.

Where should the reviewer start?

Setup a test HubSpot account - We can use xpro-dev account too but I would recommend setting up your own.

Any background context you want to provide?

We recently added VAT Id feat #2764 but this wasn't synced with hubspot

Screenshots (if appropriate)

(Optional)

What GIF best describes this PR or how it makes you feel?

(Optional)

Copy link
Contributor

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arslanashraf7 arslanashraf7 merged commit e87ea3f into master Jan 5, 2024
3 checks passed
@arslanashraf7 arslanashraf7 deleted the arslan/2847-fix-vat-id-hubspot branch January 5, 2024 13:58
@odlbot odlbot mentioned this pull request Jan 16, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants