tests: adds frontend tests for the taxes #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arslanashraf7
requested changes
Oct 2, 2023
static/js/lib/ecommerce_test.js
Outdated
| @@ -40,6 +42,82 @@ describe("ecommerce", () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe("calculateTax", () => { | |||
| it("calculates the tax of an item", () => { | |||
There was a problem hiding this comment.
nit: There are 3 similar tests below. Could you convert those into a single parameterized test? It should take price, coupon value, tax, and expected amount in the params.
There was a problem hiding this comment.
Should be resolved in b3070a7
static/js/lib/ecommerce_test.js
Outdated
| }) | ||
|
|
||
| describe("calculateTotalAfterTax", () => { | ||
| it("calculates the total including the tax for an item", () => { |
There was a problem hiding this comment.
Same as above comment.
There was a problem hiding this comment.
Should get resolved in b3070a7
arslanashraf7
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
Tests for #2769
What's this PR do?
Adds tests for #2773
How should this be manually tested?
Checks should pass.