Catalog card should show Start Anytime if the course is archived #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagav
force-pushed
the
ag/start_anytime
branch
from
01d1bed to
d026e62
Compare
annagav
force-pushed
the
ag/start_anytime
branch
from
68c11dc to
d62abcd
Compare
JenniWhitman
suggested changes
Aug 26, 2024
courses/serializers/v1/base.py
Outdated
| def get_is_archived(self, instance): | ||
| return ( | ||
| instance.is_enrollable | ||
| and instance.enrollment_end is None |
There was a problem hiding this comment.
In the get_archived_courseruns function, we defined enrollment end as able to be null or future. Here we're ONLY defining it as None. Is this the case? Should the other function be updated? Should this one?
There was a problem hiding this comment.
yep, that's a mistake.
There was a problem hiding this comment.
that condition is not needed there at all.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fix #2357
Description (What does it do?)
This PR changes the front end to use a single source of is_archived and makes the catalog display "Start Anytime" even when the course is not `is_self_paced=True'
Is archived is used in many places in the frontend, but it's value is not dynamic, so it's better to compute it in the backend.
Screenshots (if appropriate):
How can this be tested?