upgrade stories & events grid to grid2 #1792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/6007
Description (What does it do?)
This PR fixes a bug that was introduced when MUI was updated from v5 to v6 as part of #1776.
MUI v5 had
Grid
andUnstable_Grid2
components. In v6, Grid2 was stabilized Grid was deprecated. Additionally, v6 seems to have introduced a bug inGrid
. The bug only affects Grid usage that has string-values forcolumnSpacing
. We had exactly one instance of string-valuedcolumnSpacing
. So I've upgraded that particular usage toGrid2
and everything looks fine now.See mui/material-ui#44321 for MUI bug.
How can this be tested?
/departments
,/topics
,/units
,/search
,/dashboard
+ its tabs, and channel pages./dashboard/my-lists
, if one tab has 1 list and the other has 10 lists, scrollbar might affect positioning in the longer list.