fix two tests

mitodl · Aug 10, 2024 · 38159d8 · 38159d8
1 parent 4eaa4e1
commit 38159d8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/frontends/mit-open/src/components/ChannelAvatar/ChannelAvatar.test.tsx b/frontends/mit-open/src/components/ChannelAvatar/ChannelAvatar.test.tsx
@@ -12,14 +12,14 @@ describe("Avatar", () => {
       wrapper: ThemeProvider,
     })
     const img = screen.getByRole("img")
-    expect(img.getAttribute("alt")).toBe(null) // should be empty unless meaningful
+    expect(img.getAttribute("alt")).toBe("") // should be empty unless meaningful
     expect(img.getAttribute("src")).toEqual(channel.avatar_small)
   })
   it("Displays a medium avatar image by default", async () => {
     const channel = factory.channel()
     render(<ChannelAvatar channel={channel} />, { wrapper: ThemeProvider })
     const img = screen.getByRole("img")
-    expect(img.getAttribute("alt")).toBe(null) // should be empty unless meaningful
+    expect(img.getAttribute("alt")).toBe("") // should be empty unless meaningful
     expect(img.getAttribute("src")).toEqual(channel.avatar_medium)
   })
   it("Displays initials if no avatar image exists", async () => {

diff --git a/frontends/ol-components/src/components/SimpleMenu/SimpleMenu.test.tsx b/frontends/ol-components/src/components/SimpleMenu/SimpleMenu.test.tsx
@@ -147,7 +147,7 @@ describe("SimpleMenu", () => {
       wrapper: ThemeProvider,
     })
     await user.click(screen.getByRole("button", { name: "Open Menu" }))
-    const item2 = screen.getByRole("menuitem", { name: "Item 2" })
+    const item2 = screen.getByRole("link", { name: "Item 2" })
     expect(item2.dataset.reactComponent).toBe("custom-link")
     expect((item2 as HTMLAnchorElement).href).toBe(`${window.origin}/woof`)
   })