Block versioning extension #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalacho-mit
commented
Jul 1, 2024
| /* PRG ADDITION BEGIN */ | ||
| json["extensions"]?.forEach(id => extensions.extensionIDs.add(id)); | ||
|
|
||
| var extensionManager = null; |
There was a problem hiding this comment.
@mayarajan3 Are these changes still necessary?
pmalacho-mit
commented
Jul 1, 2024
src/engine/blocks.js
Outdated
| @@ -554,6 +555,13 @@ class Blocks { | |||
| // A new block was actually added to the block container, | |||
| // emit a project changed event | |||
| this.emitProjectChanged(); | |||
|
|
|||
| const scratchBlock = ScratchBlocks.getMainWorkspace().getBlockById(block.id); | |||
There was a problem hiding this comment.
Funny, I'm getting an error due to this line?
pmalacho-mit
commented
Jul 1, 2024
| @@ -440,6 +440,11 @@ class ExtensionManager { | |||
|
|
|||
| // avoid promise latency if we can call direct | |||
| const serviceObject = dispatch.services[serviceName]; | |||
| // var newFunc = funcName | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Reason for Changes
Explain why these changes should be made
Test Coverage
Please show how you have added tests to cover your changes