PHP7 support - changed 'ereg'->'preg_match' & 'split'->'explode' #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have php7 installed it won't let you add webhook unless you make these changes. Changes are pretty forward 'ereg' & 'split' were introduced in php5 but now they are deprecated
|
It took our extra effort while debugging this issue. We need to provide them with some plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge it in your plugin a lot of our clients are complaining they can't get it work with hookpress.
If you have php7 installed it won't let you add webhook unless you make these changes. Changes are pretty forward 'ereg' & 'split' were introduced in php5 but now they are deprecated, so used alternate functions.