Fix NAs in bibliography_entries()

Resolves #147
mitchelloharawild · Jan 10, 2021 · cf76529 · cf76529
1 parent c7a73d1
commit cf76529
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,10 @@
 # vitae (development version)
 
+## Bug fixes
+
+* Fixed "na.character" entries resulting in `bibliography_entries()` that differ
+  in the fields used (#147).
+
 # vitae 0.3.0
 
 This release makes substantial changes to how bibliographies included in a

diff --git a/R/bibliography.R b/R/bibliography.R
@@ -69,7 +69,7 @@ knit_print.vitae_bibliography <- function(x, options = knitr::opts_current$get()
       x <- as.list(x)
       el_is_list <- vapply(x, is.list, logical(1L))
       x[el_is_list] <- lapply(x[el_is_list], `[[`, i=1)
-      Filter(function(x) length(x) > 0, x)
+      Filter(function(x) !is.na(x) && length(x) > 0, x)
     })
   if((options$cache %||% 0) == 0) {
     file <- tempfile(fileext = ".yaml")