Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kalloc.c #268

Open
wants to merge 1 commit into
base: riscv
Choose a base branch
from
Open

Update kalloc.c #268

wants to merge 1 commit into from

Conversation

taiwoabe
Copy link

No description provided.

@taiwoabe
Copy link
Author

pull

This was referenced Oct 7, 2024
Copy link

@echtwerner echtwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to be part of PRs #264 through #268. In my opinion, it would be more efficient to combine all these related changes into a single PR, as they are interconnected and should be reviewed together.

For reference, I implemented a similar function in October 2023. It’s natural to have the desire to add functionality like freepages and freemem. However, since xv6-riscv is primarily a learning OS, it seems the maintainers do not intend to incorporate such changes into the main codebase.

Additionally, it would be greatly appreciated if the maintainers could actively close PRs that are unlikely to be accepted, to keep the repository tidy and focused.

Lastly, I want to emphasize the importance of leaving comments on PRs. They provide valuable insights and guidance to both contributors and reviewers."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants