-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test suite to support starting components asynchronously #157
base: trunk
Are you sure you want to change the base?
Refactor test suite to support starting components asynchronously #157
Conversation
@HalosGhost So far, the only commit in this PR addresses the specific issue we previously discussed: the inability of the atomizer to wait to sync with watchtowers in opencbdc-tx/tests/integration/atomizer_end_to_end_test.cpp Lines 46 to 52 in 9daab81
Is this sufficient to fix this test? I doubt it--but I don't have any way of knowing for certain right now. Unfortunately, I still can't reproduce the failures described by Issues #119 and #127. I've followed the instructions in #119:
I've also tried the following:
I recall that you may have mentioned some other way to try to trigger the problems. Could you please remind me what you said? |
Previously, the atomizer controller would make one attempt to connect to watchtowers and would return false if the attempt failed. This required watchtowers to be initialized before atomizers, which required adding a sleep to the atomizer end-to-end integration test so the watchtowers had time to initialize. This change enables the atomizer to make multiple attempts to connect to watchtowers and precludes the need for the sleep in the integration test. Signed-off-by: Michael L. Szulczewski <[email protected]>
139ec8d
to
20d7ace
Compare
Previously, controllers for components such as the atomizer archiver, sentinel, shard, and watchtower would make one attempt to connect to other components and would return false if the attempt failed. This led to lots of failures when running 'docker compose --file docker-compose-atomizer.yml up'. This commit enables components to make multiple attempts to connect. Signed-off-by: Michael L. Szulczewski <[email protected]>
This pull request addresses Issue #127.