Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 for python-afs #5

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Python 3 for python-afs #5

wants to merge 10 commits into from

Commits on Jul 27, 2020

  1. Correct documention 

    A group's membership is PTEntry.members, not PTEntry.users

Signed-off-by: Alex Dehnert <[email protected]>
    @dehnert @quentinmit
    dehnert authored and quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    5acd711 View commit details
    Browse the repository at this point in the history

  2. Notice libafsauthent_pic.a library in lib64 

    If available, we want to build against the _pic variant of the libafsauthent
library. On Fedora, that's in lib64, not lib, so we need to pick it up there
too.

Signed-off-by: Alex Dehnert <[email protected]>
    @dehnert @quentinmit
    dehnert authored and quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    11c5645 View commit details
    Browse the repository at this point in the history

  3. _pts: Remove unreachable return statements 

    Fixes
warning: afs/_pts.pyx:115:8: Unreachable code
warning: afs/_pts.pyx:130:8: Unreachable code

Signed-off-by: Anders Kaseorg <[email protected]>
    @andersk @quentinmit
    andersk authored and quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    34664fc View commit details
    Browse the repository at this point in the history

  4. _util: Remove extern from definitions that are not extern 

    Fixes
warning: afs/_util.pyx:15:5: Function 'pioctl_read' previously declared as 'private'
warning: afs/_util.pyx:29:5: Function 'pioctl_write' previously declared as 'private'

Signed-off-by: Anders Kaseorg <[email protected]>
    @andersk @quentinmit
    andersk authored and quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    af39e19 View commit details
    Browse the repository at this point in the history

  5. PTS.__cinit__: Prevent use of uninitialized security object 

    Previously, PTS.__cinit__ would leave sc uninitialized when passed an
invalid negative sec argument.

Fixes
afs/_pts.c: In function ‘__pyx_pf_3afs_4_pts_3PTS___cinit__’:
afs/_pts.c:2999:56: warning: ‘__pyx_v_sc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     (__pyx_v_serverconns[__pyx_v_i]) = rx_NewConnection((__pyx_v_info.hostAddr[__pyx_v_i]).sin_addr.s_addr, (__pyx_v_info.hostAddr[__pyx_v_i]).sin_port, PRSRV, __pyx_v_sc, __pyx_t_9);
                                                        ^

Signed-off-by: Anders Kaseorg <[email protected]>
    @andersk @quentinmit
    andersk authored and quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    ab66140 View commit details
    Browse the repository at this point in the history

  6. Use Python 3-compatible exceptions

    @quentinmit
    quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    9fff3fd View commit details
    Browse the repository at this point in the history

  7. Link against new AFS libraries

    @quentinmit
    quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    fcefc40 View commit details
    Browse the repository at this point in the history

  8. Python 3-compatible string and path handling

    @quentinmit
    quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    d919aa2 View commit details
    Browse the repository at this point in the history

  9. Bump version number

    @quentinmit
    quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    6cb4e4d View commit details
    Browse the repository at this point in the history

  10. Fix unit tests

    @quentinmit
    quentinmit committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    300a924 View commit details
    Browse the repository at this point in the history