Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make assistant tokenization error message more specific #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make assistant tokenization error message more specific #4

wants to merge 2 commits into from

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Apr 21, 2024 •
edited
Loading

Most tokenizer exception arguably come from the message being empty. Currently this gives the following error message:

'Invalid assistant message: '

which looks a bit incomplete. I think it'd be better to throw:

'Empty assistant message.'

@patrickvonplaten patrickvonplaten changed the title Update sentencepiece.py Make assistant tokenization error message more specific Apr 21, 2024
@patrickvonplaten patrickvonplaten requested a review from Bam4d April 21, 2024 12:17
@patrickvonplaten patrickvonplaten requested review from jean-malo and removed request for jean-malo August 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandora-s-git pandora-s-git pandora-s-git approved these changes

@Bam4d Bam4d Awaiting requested review from Bam4d

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickvonplaten @pandora-s-git