iOS fixes

[MrXyfir]

Fixes a few issues with the sharing process that was preventing sharing from numerous sources, including but not limited to:

• New York Times app
• Business Insider app
• Netflix app
• Audible app
• Screenshot preview

Certain types weren't being handled correctly and images weren't being saved properly.

[HarelM]

Is there a reason not to merge this?
Also I see the the parent fork is a few commits ahead, is it possible to align this fork with its parent or is there something preventing it?

[MrXyfir]

I should also add that our project no longer uses this plugin or Cordova, so if any changes are needed to this PR, someone else will have to do it. But it fixes some pretty big bugs though so it'd be nice to get it merged in for everyone else!

[HarelM]

@MrXyfir what did you end up using instead of cordova? Just out of curiosity since I'm pretty frustrated from the state of the cordova plugins and their maintenance...

[MrXyfir]

@HarelM React Native! Cordova is extremely frustrating to work with and every day it gets harder due to lack of maintenance. React Native isn't perfect, and occasionally dealing with third-party plugins like in Cordova can be frustrating, but it's a million times better than Cordova and I think the best out of all the current alternatives.

[HarelM]

I see, thanks for the info! The problem is that I need to support both a website, ios and android apps (there's just me) so I don't see how I can do it with react native, or even flutter (I might be wrong but haven't seen any evidence of these platform support web development) and still keep a single code base. I haven't seen a solution for a single code base for both web and mobile besides cordova, maybe xamirine and blazor but they are still young...

[MrXyfir]

@HarelM Yeah, fortunately for us our requirements changed and we no longer needed to support a web app so it made the switch easier.

That being said, react-native-web is a great project that lets you target the web just as you would iOS or Android in React Native! You would definitely need some platform-specific code for certain things, even sometimes iOS and Android need different code in React Native, although the majority of stuff works on both right out of the box!

Depending on your requirements, Expo might make things a lot easier in React Native, but it's more limited in its features.

An interesting idea for you to look into is using react-native-webview so you can embed a browser into your app to load parts of your website and then you can inject JavaScript code into the web page and listen for messages so in this way your website could communicate with React Native and you could run any native code that you need while keeping most of the interface and functionality on your website.

[HarelM]

Thanks for the super detailed response! It was a pleasure reading it and learning things I have missed.
My main concern/problem is that my app is a navigation app that relies heavily on Mapbox, which does not play well when it comes to full cross platforms that are not webview based. Migrating to react-native and using a webview seems like the same problem I'm having now in theory, maybe apart from plugins that are covered by Expo and hopefully maintained better.
There's a feature request to support Mapbox in Expo, maybe when this is implemented I can consider switching, although there's a lot of code to migrate and a lot of quirks I have fixed in the past that I'll need to make sure are working again... So if switching I need to be sure all the native functionality is supported and which "SDK" (Expo+react-native/blazor+xamirine) is the best candidate when doing that switch.
In any case, I'll keep an eye on Expo, as it seems to go in the right direction... :-)
My server side code is .net core so blazor can benefit from better code sharing in theory, but I feel it needs to mature as it feels like it's missing a lot of basic stuff...

[MrXyfir]

I'm glad I could help! I wish you the best of luck with your app, and if you ever have any questions I'd be happy to try and answer them.

[HarelM]

Thanks! One last question, why did you decide to use/send a PR to this plugin and not the original fork (https://github.com/j3k0/cordova-plugin-openwith)?
I'm wondering where to invest my effort...

[MrXyfir]

I tried almost every single plugin and fork that was available and this was the only one I could get to work...