Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ajout notice sifa + amélioration du style de la page #3310

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

totakoko
Copy link
Contributor

image

@totakoko totakoko requested a review from rap2hpoutre October 23, 2023 15:40
@github-actions
Copy link

🚀 Prévisualisation

https://3310.tdb-preview.apprentissage.beta.gouv.fr/

@totakoko totakoko enabled auto-merge (squash) October 23, 2023 16:01
Copy link
Contributor

@rap2hpoutre rap2hpoutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUper

Attention
</Text>
<Text color="grey.800">
Vérifiez que tous vos apprentis soient bien présents dans le fichier. Sinon, complétez-le.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'aurais dit qu'ils "sont" pas qu'ils "soient", mais j'ai un doute il est possible que les deux se disent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Faites attention à ce qu'ils soient...
  • Vérifiez qu'ils sont...

En effet ça me parait un peu plus naturel, mais ça parait aussi correct.
Bon ben c'est de toute façon parti avec l'automerge :trollface: (faudrait peut-être pas que je l'active tout le temps celui-là...)

@totakoko totakoko merged commit e5fd468 into master Oct 23, 2023
@totakoko totakoko deleted the ajout_notice_sifa branch October 23, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants