Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stack upgrade #3307

Merged
merged 17 commits into from
Oct 24, 2023
Merged

feat: stack upgrade #3307

merged 17 commits into from
Oct 24, 2023

Conversation

moroine
Copy link
Contributor

@moroine moroine commented Oct 23, 2023

Changements:

  • Limit docker builder cache size in preview
  • yarn setup will apply migrations & create indexes
  • Preview deployment is not automatic anymore for each commit but trigger via a comment in the PR with a 🚀
  • Prevent race conditions in preview by using mutex (serveur cannot handle concurrent build & seed in parallel)
  • Add gitguardian
  • Support github merge queue
  • Logs send to monitoring in json format
  • Better caching in Dockerfile
  • Do not run job processor in preview
  • Better jobs schema (cron vs simple vs cron_task)
  • Simplify crons definitions
  • ⚠️ Migration to clear all jobs history
  • yarn dev in server watches shared
  • fix ui Sentry tracePropagationTargets

@moroine moroine marked this pull request as ready for review October 23, 2023 11:20
@rap2hpoutre
Copy link
Contributor

Les tests ne passent pas j'imagine qu'il vaut mieux attendre qu'ils passent ?

@moroine
Copy link
Contributor Author

moroine commented Oct 24, 2023

Les tests ne passent pas j'imagine qu'il vaut mieux attendre qu'ils passent ?

@rap2hpoutre yes, il y a des memory leaks dans l'app j'ai l'impression

@github-actions
Copy link

🚀 Prévisualisation

https://3307.tdb-preview.apprentissage.beta.gouv.fr/

Copy link
Contributor

@totakoko totakoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y'aurait moyen d'avoir quelques infos sur les changements majeurs apportés par cette PR ? Car stack upgrade ne véhicule pas beaucoup d'information... 😉

@github-actions
Copy link

To deploy this PR just add a comment with a simple 🚀

@moroine moroine merged commit 7309711 into master Oct 24, 2023
7 checks passed
@moroine moroine deleted the feature/upgrade-stack branch October 24, 2023 12:29
@github-actions
Copy link

🎉 This PR is included in version 3.70.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants