fix: maj de zod #3276
Merged
fix: maj de zod #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rap2hpoutre
approved these changes
Oct 9, 2023
Et openapi au passage pour rester compatible
|
J'ai rebase sur master pour résoudre le conflit et je merge ! 🎉 |
🚀 Prévisualisation |
|
🎉 This PR is included in version 3.60.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J'ai corrigé un test concernant le téléphone, mais je pense que ce n'était pas dû à zod mais plutôt à notre processus de validation un peu bancal. Du coup j'ai inversé les choses pour valider puis transformer.
Les emails fonctionnent également concernant les email de la forme "[email protected]". Jai ajouté un test sur zod au cas où.
Ça serait peut-être intéressant de tester unitairement chaque primitive zod utilisée dans l'API v3.