fix corner case in dead_code

fixes #5941
mishoo · Sep 28, 2024 · 1077323 · 1077323
1 parent d460c70
commit 1077323
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/compress.js b/lib/compress.js
@@ -13146,7 +13146,9 @@ Compressor.prototype.compress = function(node) {
                     node = parent;
                     parent = compressor.parent(level++);
                     if (parent instanceof AST_Assign) {
-                        if (parent.left instanceof AST_SymbolRef && parent.left.definition() === def) {
+                        if (parent.right === node
+                            && parent.left instanceof AST_SymbolRef
+                            && parent.left.definition() === def) {
                             if (in_try(level, parent, !local)) break;
                             return strip_assignment(def);
                         }

diff --git a/test/compress/assignments.js b/test/compress/assignments.js
@@ -862,3 +862,21 @@ issue_5670: {
     }
     expect_stdout: "PASS"
 }
+
+issue_5941: {
+    options = {
+        assignments: true,
+        conditionals: true,
+        dead_code: true,
+    }
+    input: {
+        var a = 1;
+        a = a &&= (a = console) && console.log(typeof a);
+    }
+    expect: {
+        var a = 1;
+        a = (a = a && console) && console.log(typeof a);
+    }
+    expect_stdout: "object"
+    node_version: ">=15"
+}