Move WebSocketConnectionError to exceptions (#1026) #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 115 115
Lines 7762 7763 +1
=======================================
+ Hits 7593 7594 +1
Misses 169 169
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AdemOdza
force-pushed
the
moveWebSocketConnectionError
branch
from
945b41b
to
d691629
Compare
rafalp
approved these changes
Oct 11, 2023
|
Looking good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #1026
There was a request for this, and it seems clearer to have the WebSocketConnectionError with the other exceptions rather than with the types.