Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app manifest terms banner #269

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Update app manifest terms banner #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
174e25c
updating app manifest and README for AWS examples
horeaporutiu Mar 19, 2024
4daf074
updating app manifest and README for AWS examples
horeaporutiu Mar 19, 2024
172bdc6
updating app manifest and README for AWS examples
horeaporutiu Mar 19, 2024
a95c9e4
updating app manifest and README for AWS examples
horeaporutiu Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/terms-modal-banner-dynamodb/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@ Once you have finished all of the steps related to AWS in the [developer tutoria

1. In your new Miro app settings, add in the `App URL`. It should end with `webassets/app.html`.
2. Open the [app manifest editor](https://developers.miro.com/docs/manually-create-an-app#step-2-configure-your-app-in-miro) by clicking **Edit in Manifest**. \
In the app manifest editor, configure the app as follows <b> ⚠️ Note: you will need to change your sdkUri to be your app.html which is hosted in the `webassets` folder of your S3 bucket. Mine is just shown as an example </b> and then click save:
In the app manifest editor, configure the app as follows <b> ⚠️ Note: you will need to change your sdkUri to be your app.html which is hosted in the `webassets` folder of your S3 bucket. Your `sdkUri` will be the public endpoint to your app.html file. Mine is just shown as an example </b> so make sure to change it to point to your `app.html file` and then click save:
mettin marked this conversation as resolved.
Show resolved Hide resolved

```yaml
# See https://developers.miro.com/docs/app-manifest on how to use this
appName: s3-modal-banner
appName: dynamodb-modal-banner
sdkVersion: SDK_V2
sdkUri: >-
https://s3-miro-terms-banner-12345.s3.amazonaws.com/webassets/app.html
https://dynamodb-miro-terms-banner-12345.s3.amazonaws.com/webassets/app.html
scopes:
- identity:read
```
Expand Down
8 changes: 8 additions & 0 deletions examples/terms-modal-banner-dynamodb/app-manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# See https://developers.miro.com/docs/app-manifest on how to use this
# make sure to replace the sdkUri with the correct URL (it will be different for each deployment)
appName: dynamodb-modal-banner
sdkVersion: SDK_V2
sdkUri: >-
https://dynamodb-miro-terms-banner-12345.s3.amazonaws.com/webassets/app.html
scopes:
- identity:read
2 changes: 1 addition & 1 deletion examples/terms-modal-banner-s3/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Once you have finished all of the steps related to AWS in the [developer tutoria

1. In your new Miro app settings, add in the `App URL`. It should end with `webassets/app.html`.
2. Open the [app manifest editor](https://developers.miro.com/docs/manually-create-an-app#step-2-configure-your-app-in-miro) by clicking **Edit in Manifest**. \
In the app manifest editor, configure the app as follows <b> ⚠️ Note: you will need to change your sdkUri to be your app.html which is hosted in the `webassets` folder of your S3 bucket. Mine is just shown as an example </b> and then click save:
In the app manifest editor, configure the app as follows <b> ⚠️ Note: you will need to change your sdkUri to be your app.html which is hosted in the `webassets` folder of your S3 bucket. Your `sdkUri` will be the public endpoint to your app.html file. Mine is just shown as an example </b> so make sure to change it to point to your `app.html file` and then click save:

```yaml
# See https://developers.miro.com/docs/app-manifest on how to use this
Expand Down
Loading