Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breakout Rooms] Improve split users functionality #236

Closed
wants to merge 4 commits into from
+6 −4
Closed

[Breakout Rooms] Improve split users functionality #236

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61ac30b
Iterate handleSplitUsers so it always tries to add user to room with …
Dec 12, 2023
af7caf0
[Breakout Rooms] UI and UX improvements (#235)
dfosco Dec 19, 2023
af292e5
Fix handleSplitUsers() to include last user when number of users was odd
Jan 23, 2024
9a2ba43
Merge branch 'main' into dfosco/improve-split-users
dfosco Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,19 +131,21 @@ export const BreakoutManager: React.FC = () => {

const handleSplitUsers = async () => {
const count = rooms.length;

// This needs to be only new users
const users = unassignedUsers;
const roomSize = Math.max(Math.floor(users.length / count), 1);

const roomSize = Math.max(Math.ceil(users.length / count), 1);
const usersInRooms: OnlineUserInfo[][] = [];

for (let i = 0; i < users.length; i += roomSize) {
usersInRooms.push(users.slice(i, i + roomSize));
}

// Sort rooms by number of participants in ascending order
const sortedRooms = [...rooms].sort((a, b) => a.participants.length - b.participants.length);

for (let i = 0; i < count; ++i) {
const room = rooms[i];
const room = sortedRooms[i];
const participants = usersInRooms[i];
for (const participant of participants) {
await service.addParticipant(room, participant);
Expand Down
Loading