[Breakout Rooms] UI and UX improvements #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 12, 2023 15:23
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dfosco
changed the title
mettin
approved these changes
Dec 13, 2023
examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx
Outdated
Show resolved
Hide resolved
examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx
Outdated
Show resolved
Hide resolved
examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx
Outdated
Show resolved
Hide resolved
examples/breakout-rooms/src/components/BreakoutStarter/BreakoutStarter.css
Outdated
Show resolved
Hide resolved
examples/breakout-rooms/src/components/BreakoutStarter/BreakoutStarter.css
Outdated
Show resolved
Hide resolved
fredcido
reviewed
Dec 13, 2023
examples/breakout-rooms/src/components/RoomConfig/RoomConfig.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
December 13, 2023 10:29
dfosco
force-pushed
the
dfosco/breakout-rooms-ui-fixes
branch
from
d499269 to
d1ca737
Compare
dfosco
changed the title
…tManager.tsx Co-authored-by: Mettin Parzinski <[email protected]>
…tManager.tsx Co-authored-by: Mettin Parzinski <[email protected]>
Co-authored-by: Frederico Estrela <[email protected]>
…tManager.tsx Co-authored-by: Mettin Parzinski <[email protected]>
|
I'm getting some errors on the latest commit that do not seem to break the app — @fredcido might be related to the realtime storage problems we found? 
|
This was referenced Dec 13, 2023
mettin
approved these changes
Dec 13, 2023
examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx
Outdated
Show resolved
Hide resolved
examples/breakout-rooms/src/components/WaitingList/WaitingList.tsx
Outdated
Show resolved
Hide resolved
fredcido
approved these changes
Dec 19, 2023
dfosco
added a commit
that referenced
this pull request
Jan 23, 2024
* Fix UI on empty state button * Fix list of validations to always show missing steps * Improve style in validations * Make copy in user(s) splitting block dynamic * Update 'Waiting room' copy on user selection dropdown * UI and copy fixes in Room block * Button size adjusted in waiting room * Improve copy and UI for frame selection * Fix rooms container height * Fix copy * Increase timer limit and add +5min option * CSS fixes * Remove CSS nesting * Update toast copy * Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx Co-authored-by: Mettin Parzinski <[email protected]> * Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx Co-authored-by: Mettin Parzinski <[email protected]> * Update examples/breakout-rooms/src/components/RoomConfig/RoomConfig.tsx Co-authored-by: Frederico Estrela <[email protected]> * Iterate frame title rendering when set to room * Update styles * Update relative timer rendering to change timer button text Update finish session button variant * Improve styles and dropdown separator * One more style fix * One more more style fix * Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx Co-authored-by: Mettin Parzinski <[email protected]> * Fix broken copy * Add CSS class to avoid li+li --------- Co-authored-by: Mettin Parzinski <[email protected]> Co-authored-by: Frederico Estrela <[email protected]>
dfosco
added a commit
that referenced
this pull request
Jan 23, 2024
* Fix UI on empty state button * Fix list of validations to always show missing steps * Improve style in validations * Make copy in user(s) splitting block dynamic * Update 'Waiting room' copy on user selection dropdown * UI and copy fixes in Room block * Button size adjusted in waiting room * Improve copy and UI for frame selection * Fix rooms container height * Fix copy * Increase timer limit and add +5min option * CSS fixes * Remove CSS nesting * Update toast copy * Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx Co-authored-by: Mettin Parzinski <[email protected]> * Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx Co-authored-by: Mettin Parzinski <[email protected]> * Update examples/breakout-rooms/src/components/RoomConfig/RoomConfig.tsx Co-authored-by: Frederico Estrela <[email protected]> * Iterate frame title rendering when set to room * Update styles * Update relative timer rendering to change timer button text Update finish session button variant * Improve styles and dropdown separator * One more style fix * One more more style fix * Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx Co-authored-by: Mettin Parzinski <[email protected]> * Fix broken copy * Add CSS class to avoid li+li --------- Co-authored-by: Mettin Parzinski <[email protected]> Co-authored-by: Frederico Estrela <[email protected]>
dfosco
added a commit
that referenced
this pull request
Jan 24, 2024
* Fix UI on empty state button * Fix list of validations to always show missing steps * Improve style in validations * Make copy in user(s) splitting block dynamic * Update 'Waiting room' copy on user selection dropdown * UI and copy fixes in Room block * Button size adjusted in waiting room * Improve copy and UI for frame selection * Fix rooms container height * Fix copy * Increase timer limit and add +5min option * CSS fixes * Remove CSS nesting * Update toast copy * Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx Co-authored-by: Mettin Parzinski <[email protected]> * Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx Co-authored-by: Mettin Parzinski <[email protected]> * Update examples/breakout-rooms/src/components/RoomConfig/RoomConfig.tsx Co-authored-by: Frederico Estrela <[email protected]> * Iterate frame title rendering when set to room * Update styles * Update relative timer rendering to change timer button text Update finish session button variant * Improve styles and dropdown separator * One more style fix * One more more style fix * Update examples/breakout-rooms/src/components/BreakoutManager/BreakoutManager.tsx Co-authored-by: Mettin Parzinski <[email protected]> * Fix broken copy * Add CSS class to avoid li+li --------- Co-authored-by: Mettin Parzinski <[email protected]> Co-authored-by: Frederico Estrela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current / New