Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build check for cases when dependabot update breaks the build #229

Merged
merged 6 commits into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/dependabot-auto-merge.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Dependabot
on: pull_request

on:
pull_request:
branches:
- "dependabot/**"

permissions:
pull-requests: write
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ jobs:

steps:
- name: Check out Git repository
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Read .nvmrc
run: echo ::set-output name=NVMRC::$(cat .nvmrc)
id: nvm

- name: Setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: "${{ steps.nvm.outputs.NVMRC }}"

Expand All @@ -33,6 +33,9 @@ jobs:
- name: Check format
run: yarn prettier --check ./examples

- name: Check build
run: yarn run build

- name: Check python code
uses: psf/black@stable
with:
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v20.7.0
2 changes: 1 addition & 1 deletion examples/breakout-rooms/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
"@types/react-dom": "^18.0.8",
"@vitejs/plugin-react": "^2.2.0",
"typescript": "4.9.5",
"vite": "2.9.16"
"vite": "3.2.7"
}
}
2 changes: 1 addition & 1 deletion examples/csv-to-mindmap/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@
"@types/react-dom": "^18.0.8",
"@vitejs/plugin-react": "^2.2.0",
"typescript": "4.8.4",
"vite": "2.9.16"
"vite": "3.2.7"
}
}
2 changes: 1 addition & 1 deletion examples/csv-to-mindmap/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dns.setDefaultResultOrder("verbatim");
const allHtmlEntries = fs
.readdirSync(".")
.filter((file) => path.extname(file) === ".html")
.reduce((acc, file) => {
.reduce((acc: Record<string, string>, file) => {
acc[path.basename(file, ".html")] = path.resolve(__dirname, file);

return acc;
Expand Down
2 changes: 1 addition & 1 deletion examples/selfie-with-custom-action/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"react-dom": "^18.2.0"
},
"devDependencies": {
"vite": "2.9.16",
"vite": "3.0.3",
"@mirohq/websdk-types": "latest",
"@types/react": "^18.0.24",
"@types/react-dom": "^18.0.8",
Expand Down
2 changes: 1 addition & 1 deletion examples/selfie-with-custom-action/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dns.setDefaultResultOrder("verbatim");
const allHtmlEntries = fs
.readdirSync(".")
.filter((file) => path.extname(file) === ".html")
.reduce((acc, file) => {
.reduce((acc: Record<string, string>, file) => {
acc[path.basename(file, ".html")] = path.resolve(__dirname, file);

return acc;
Expand Down
Loading
Loading