Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding details to change github action to point to serverless endpoint #204

Merged
merged 3 commits into from
Oct 10, 2023
Merged

adding details to change github action to point to serverless endpoint #204

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dd8c7c
adding details to change github action to point to serverless endpoint
horeaporutiu Oct 10, 2023
4b46c96
adding details to change github action to point to serverless endpoint
horeaporutiu Oct 10, 2023
8174a39
fix links to github actions
horeaporutiu Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/github-appcards/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,10 @@ MIRO_REDIRECT_URI=https://peaceful-fairy-c2e727.netlify.app/.netlify/functions/a
<b>Make sure your URLs have https:// at the beginning, otherwise the OAuth flow will not work.</b>
Also make sure that your MIRO_REDIRECT_URI ends in `.netlify/functions/authorize`.

8. Lastly, you will need to change the URL in the GitHub action to point to your own deployed serverless functions. Point your GitHub action for `issues` to point to your `issues` endpoint from your serverless functions. The same should be done for `project-cards`.
Go to [.github/workflows/issues.yml](.github/workflows/issues.yml) and change the URL on [line 11](.github/workflows/issues.yml#L11).
Go to [.github/workflows/project-cards.yml](.github/workflows/project-cards.yml) and change the URL [on line 13](.github/workflows/project-cards.yml#L13).

Comment on lines +209 to +212
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a bit ugly. Are these "go to" supposed to be as list items?

image

Suggested change
8. Lastly, you will need to change the URL in the GitHub action to point to your own deployed serverless functions. Point your GitHub action for `issues` to point to your `issues` endpoint from your serverless functions. The same should be done for `project-cards`.
Go to [.github/workflows/issues.yml](.github/workflows/issues.yml) and change the URL on [line 11](.github/workflows/issues.yml#L11).
Go to [.github/workflows/project-cards.yml](.github/workflows/project-cards.yml) and change the URL [on line 13](.github/workflows/project-cards.yml#L13).
8. Lastly, you will need to change the URL in the GitHub action to point to your own deployed serverless functions. Point your GitHub action for `issues` to point to your `issues` endpoint from your serverless functions. The same should be done for `project-cards`.
- Go to [.github/workflows/issues.yml](.github/workflows/issues.yml) and change the URL on [line 11](.github/workflows/issues.yml#L11).
- Go to [.github/workflows/project-cards.yml](.github/workflows/project-cards.yml) and change the URL [on line 13](.github/workflows/project-cards.yml#L13).

# 🏃🏽‍♂️ Run the app <a name="run"></a>

1. Go back to your app home page, and under the `Share app` section, click on `Copy` and paste the URL in your browser. Install the app on a dev team.
Expand Down
Loading