Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PF-1489 - Adding selfie app example #197

Merged
merged 6 commits into from
Sep 25, 2023
Merged

PF-1489 - Adding selfie app example #197

merged 6 commits into from
Sep 25, 2023

Conversation

fredcido
Copy link
Contributor

@fredcido fredcido commented Sep 25, 2023 •
edited
Loading

Adding app example to take user's selfie and allow updating the image with custom actions.

@vercel
Copy link

vercel bot commented Sep 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-examples-wordle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 2:42pm
webhooks-manager ❌ Failed (Inspect) Sep 25, 2023 2:42pm

@fredcido fredcido marked this pull request as ready for review September 25, 2023 09:45
@fredcido fredcido requested a review from a team as a code owner September 25, 2023 09:45
mettin
mettin approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@mettin mettin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the example's folder name to include custom-action?

examples/selfie/README.md Outdated Show resolved Hide resolved
examples/selfie/package.json Outdated Show resolved Hide resolved
examples/selfie/src/app.tsx Outdated Show resolved Hide resolved
examples/selfie/src/index.ts Outdated Show resolved Hide resolved
@fredcido fredcido enabled auto-merge (squash) September 25, 2023 13:59
@fredcido fredcido merged commit dcaa99f into main Sep 25, 2023
2 checks passed
@fredcido fredcido deleted the PF-1489-self-image branch September 25, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyroux anthonyroux anthonyroux left review comments

@ggasimzada-miro ggasimzada-miro ggasimzada-miro approved these changes

@mettin mettin mettin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredcido @anthonyroux @mettin @ggasimzada-miro