ACCDT-1239: reduce cardinality of metrics #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylomiro
approved these changes
Nov 14, 2023
kyrylomiro
reviewed
Nov 15, 2023
| @@ -64,6 +64,10 @@ func (reader *EventReader) ProcessWorkflowJobEvent(ctx context.Context, event in | |||
| keysAndValues = []interface{}{"job_id", fmt.Sprint(*e.WorkflowJob.ID)} | |||
| ) | |||
|
|
|||
| if len(e.WorkflowJob.Labels) == 0 { | |||
There was a problem hiding this comment.
have you checked, what is the cases when we have this empty? just to understand what we are dropping?
There was a problem hiding this comment.
@kyrylomiro I looked into it a bit, and so far, no run labels appear when no runner was started for the job. This happens when:
- the job calls a reusable workflow. the root job doesn't have runners, but sub jobs in the workflow appears and have runners
- the job has an if statement that wasn't fulfilled
- the job wasn't triggered, due to previous dependency
- it is a check added by an app, and not an actual job (e.g. miro:version)
So I think it should be okay to skip over them. I will do a bit more deep dive after lunch
There was a problem hiding this comment.
Looks like the list above is accurate. So it should be okay to skip those entries for the metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
[ACCDT-1239]
Currently the volume of metrics is too high due to cardinality. This was remedied before by using metric relabelings, but there are benefits of applying the change directly in the producing code.
Proposed Changes