Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict rf stat #323

Closed
wants to merge 7 commits into from
Closed

Predict rf stat #323

wants to merge 7 commits into from

Conversation

pl0xz0rz
Copy link
Contributor

This PR:
-Makes multiselect widget work with new pandas
-Removes one liner utility functions from #320, performance of predictRFStat improved by further 10%

@miranov25
Copy link
Owner

Did we have an issue created for the categorical multi-select pandas?

  • if yes -can you add it?
  • if not can you describe what you actually did?

@miranov25
Copy link
Owner

Checking source code changes for categorical - is it related only to the output table, so it is only new feature?

@miranov25
Copy link
Owner

We forgot to merge this request. Is this code compatible with the LinearRegression pull request?

@pl0xz0rz
Copy link
Contributor Author

pl0xz0rz commented May 3, 2023

No, but manually merging it shouldn't be an issue, the only merge conflict should be a single line in the makeBokehMultiSelectSlider

EDIT: Seems I have accidentally managed to apply this PR's changes to the branch I used to make linear regression on the client

@miranov25
Copy link
Owner

Fixed as side change in pull request #325

@miranov25 miranov25 closed this May 15, 2023
@pl0xz0rz pl0xz0rz deleted the predictRFStat branch May 22, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants