Pure dec enc with gz #143
Merged
Pure dec enc with gz #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which will produce an other GADT value and Tar_{,lwt_}unix which evaluate our GADT
reynir
reviewed
Feb 7, 2024
lib/tar.ml
Outdated
| | Really_read : int -> (string, 'err) t | ||
| | Read : int -> (string, 'err) t | ||
| | Seek : int -> (int, 'err) t | ||
| | Bind : ('a, 'err) t * ('a -> ('b, 'err) t) -> ('b, 'err) t |
There was a problem hiding this comment.
For Bind (x, f) the values x and f share the same 'err. This is likely just fine, but it could maybe be generalized (though I don't think it's worth it going through those hoops).
| else until_full_or_end (Gz.Inf.flush state.gz) (res, len, Bytes.length res - len) | ||
|
|
||
| let really_read_through_gz decoder len = | ||
| let open Tar in |
There was a problem hiding this comment.
Here we locally open Tar to get let* only? Then maybe
Suggested change
| let open Tar in | |
| let ( let* ) = Tar.( let* ) in |
reynir
reviewed
Feb 7, 2024
We can list .tar.gz archives that consists of directories and empty files \o/ files with content is not possible /o\
The position is not always possible to keep track of, and is not very useful to begin with. The documentation better explains the lightweight higher kinded types trick. Co-authored-by: Calascibetta Romain <[email protected]> Co-authored-by: Reynir Björnsson <[email protected]>
Co-authored-by: Calascibetta Romain <[email protected]> Co-authored-by: Reynir Björnsson <[email protected]>
Merged
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Aug 5, 2024
CHANGES: - Fix `Header.marshal` and the checksum and the length (@reynir, mirage/ocaml-tar#145) - Delete a mutable field about the level into the header (@hannesm, mirage/ocaml-tar#141) - **BREAKING**: de-functorize the package (@hannesm, @reynir, @dinosaure, mirage/ocaml-tar#140, mirage/ocaml-tar#143, mirage/ocaml-tar#146) These PRs attempt to de-functorize `Tar` so that users can implement I/O themselves, using `Tar`'s own element serialization/deserialization functions to take advantage of read/write methods. This avoids imposing on the user the implementation of a module that is too rigid in his/her case (which could have performance implications). `Tar` offers functions for serializing/deserializing tar-specific elements from `string`. It is then up to the user to know how to obtain or write these `strings`. To this, these PRs add "logics" (see `'a Tar.t`) requiring read and/or write implementations and describing how to extract all entries from a tar file or how to write a tar file according to a "dispenser" (like `Seq.to_dispenser`) of entries. These logics do not depend on a particular "scheduler", and these PRs propose a derivation of these logics with `tar-unix`, `tar-eio` and `tar-mirage`. These latter derivations mean that the API for these packages has only been extended, and there are no breaking changes as such. These logics also make it easy to offer a compression/decompression layer with `decompress`, so you can easily manipulate and/or create a .tar.gz file.
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: - Fix `Header.marshal` and the checksum and the length (@reynir, mirage/ocaml-tar#145) - Delete a mutable field about the level into the header (@hannesm, mirage/ocaml-tar#141) - **BREAKING**: de-functorize the package (@hannesm, @reynir, @dinosaure, mirage/ocaml-tar#140, mirage/ocaml-tar#143, mirage/ocaml-tar#146) These PRs attempt to de-functorize `Tar` so that users can implement I/O themselves, using `Tar`'s own element serialization/deserialization functions to take advantage of read/write methods. This avoids imposing on the user the implementation of a module that is too rigid in his/her case (which could have performance implications). `Tar` offers functions for serializing/deserializing tar-specific elements from `string`. It is then up to the user to know how to obtain or write these `strings`. To this, these PRs add "logics" (see `'a Tar.t`) requiring read and/or write implementations and describing how to extract all entries from a tar file or how to write a tar file according to a "dispenser" (like `Seq.to_dispenser`) of entries. These logics do not depend on a particular "scheduler", and these PRs propose a derivation of these logics with `tar-unix`, `tar-eio` and `tar-mirage`. These latter derivations mean that the API for these packages has only been extended, and there are no breaking changes as such. These logics also make it easy to offer a compression/decompression layer with `decompress`, so you can easily manipulate and/or create a .tar.gz file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @hannesm on top of #140
This is an attempt to implement
Tar_gzwithout requiring I/O. The idea is to describe fold with a GADT instead of using I/O functions directly.Tar_gzthen maps these values to introduce the compression level. Finally,Tar_unixandTar_lwt_unixreuse this GADT with a specific evaluation depending on the backend.However, as far as
Tar_lwt_unixis concerned, the user function cannot currently return an Lwt value. Several solutions exist. The one I've currently used is like the one forawa-ssh, a list of threads that grows (and that we have to resolve) according to the fold computation. Another solution is to make GADT more expressive with the Yallop trick, as I've done here.