Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support eio>=0.12 #134

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Support eio>=0.12 #134

wants to merge 5 commits into from

Conversation

samoht
Copy link
Member

@samoht samoht commented Nov 3, 2023 •
edited
Loading

@samoht samoht force-pushed the eio-0.12 branch 2 times, most recently from dc9e462 to bd9fc0b Compare November 4, 2023 22:48
@samoht
Copy link
Member Author

samoht commented Nov 4, 2023

This work but I'd like to improve the API a bit. The streaming API is very confusing (as it doesn't skip the correct bytes in the stream by default). I would also like to change the function and type names to reflect eio naming scheme.

@samoht
Add a fold function to tar_eio_gz
26a561e
@samoht
Avoid an allocation on every skip
c3455a1 
Not sure it's thread safe but nobody is reading in that buffer anyway.
Would be better do have Flow.skip?
@samoht
Better implementation for fold
a7999fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samoht