WIP: merge divergent branches: main and git-protcol-v2 PR #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make client, server capabilities management more explicit
* rename 'decoder_from' to more conventional 'of_string' * add safer version of peek pkt that also support git wire protocol v2 pkts: delim-pkt and response-end-pkt * move 'prompt_pkt' to 'decoder.mli' to reuse it in git wire proto v2 * add 'read_pkt' * add 'junk_chars' fn to 'Decoder' to increase 'decoder.pos' by 'n' * move 'bind' and '>>=' from nss/protocol.ml to pkt_line.decoder * [wip] support wire proto v2 capabilities * add 'Ls_refs', 'Fetch_command' modules to represent commands 'ls-refs' and 'fetch' respectively; * add 'Encoder' module to wire-proto-v2 with support for encoding command requests and copy-paste NSS's 'encode_proto_request' * add some comments to better define parts of a packet line: specific names for 4 bytes that encode packet length, the bytes that follow the length bytes, etc. * rename length calculating function 'pkt_len' to 'encoded_pkt_len' that returns the value hex-encoded in the first 4 bytes of the packet line and 'pkt_len_at_least_4' returns 'max 4 (encoded_pkt_len pkt)' * copy-paste 'Proto_request' module from NSS * update 'response' type in proto-v2 'Protocol' * add 'Extended_pkt_line_decoder' that provides more functionality than 'Pkt_line.Decoder' but not specific to the protocol * add decoding for all commands of wire proto v2 * reflect changes after 'mimic' lib introduction * make 'smart_flow' more understandable * reduce dup code, e.g., (>>=) * reorganize stuff closer to its use * rename stuff for more clarity * move smart protocol (wire proto v1)-based 'fetch' code to separate modules * functorize 'Smart_flow' * rename 'Smart_flow' to 'State_flow' * add mli file to 'State_flow' * improve 'nss/state.ml' API: - it improves cases when we want to "open" the module to get infix/syntax operators - it also make the API more uniform and rich, e.g., adds "map" fn * rename "fail" to "io_raise": 1) avoid clash with "fail" from "smart"/"wire_proto_v2" 2) to highlight that it causes "exception"al behavior * add support for "ls-refs" command (without args) * fix log.debug use and its message
a module that translates state read-write monad into 'flow' operations, to be usable both by 'Smart' and 'Wire_proto_v2'; hence, they shouldn't have own copies of Context
…r-param to Smart_git.Make
…signature in test/smart/test.ml
… out-commenting dependent code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.