Handle vat shutdown while connecting #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a vat is shut down it ends all registered connections and stops accepting new ones. However, if a connection was in progress (e.g. doing the TLS handshake but not yet registered) then we would miss it. The `test_parallel_fails` test got upgraded to the stricter `await_settled_exn` in mirage#233, which was wrong but that wasn't detected due to this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a vat is shut down it ends all registered connections and stops accepting new ones. However, if a connection was in progress (e.g. doing the TLS handshake but not yet registered) then we would miss it.
The
test_parallel_failstest got upgraded to the stricterawait_settled_exnin #233, which was wrong but that wasn't detected due to this bug.