Respects explicit formatted="false" tag in strings #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is valid for Android XML files to have strings that disregard the formatting characters (like percent) by setting the tag formatted="false", such as: <string name="discount" formatted="false">50% off</string> This tag was previously not being carried through an export/import cycle. Now it is tracked properly. In the po file we will store the flag "no-c-format" to mean formatted="false" in the XML. Note: this is only implemented for <string> at this time, not <plurals> and <string-array>. Closes miracle2k#24
brentinrochester
force-pushed
the
master
branch
2 times, most recently
from
f5040b6
to
d1ccfa1
Compare
The tox was configured to use notestests which do not support python 10.
brentinrochester
force-pushed
the
master
branch
from
d1ccfa1
to
ee3dd3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is valid for Android XML files to have strings that disregard the formatting characters (like percent) by setting the tag formatted="false", such as:
<string name="discount" formatted="false">50% off</string>This tag was previously not being carried through an export/import cycle. Now it is tracked properly. In the po file we will store the flag "no-c-format" to mean formatted="false" in the XML.
Note: this is only implemented for "string" at this time, not "plurals" and "string-array".
Closes #24 #26