Skip to content

Commit

Permalink
Added GLOBAL_GRPC_OPTIONS to Ray Client GRPC_OPTIONS (ray-project#40490)
Browse files Browse the repository at this point in the history
GRPC options of the client now extends the GLOBAL_GRPC_OPTIONS constant. Doing so allows the Ray client to obey the expected http/s proxy behaviour. Also gives the user to override this behaviour with the RAY_grpc_enable_http_proxy environment variable.
  • Loading branch information
batuhanfaik authored Oct 27, 2023
1 parent 19e6db9 commit 136b73d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions python/ray/util/client/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import ray._raylet as raylet
import ray.core.generated.ray_client_pb2 as ray_client_pb2
import ray.core.generated.ray_client_pb2_grpc as ray_client_pb2_grpc
from ray._private import ray_constants
from ray._private.inspect_util import (
is_class_method,
is_cython,
Expand Down Expand Up @@ -65,6 +66,7 @@
GRPC_KEEPALIVE_TIMEOUT_MS = 1000 * 600

GRPC_OPTIONS = [
*ray_constants.GLOBAL_GRPC_OPTIONS,
("grpc.max_send_message_length", GRPC_MAX_MESSAGE_SIZE),
("grpc.max_receive_message_length", GRPC_MAX_MESSAGE_SIZE),
("grpc.keepalive_time_ms", GRPC_KEEPALIVE_TIME_MS),
Expand Down

0 comments on commit 136b73d

Please sign in to comment.