Skip to content
This repository has been archived by the owner on Sep 12, 2021. It is now read-only.

[WIP] Add implementation for RequestBuilder and Response #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Add implementation for RequestBuilder and Response #8

wants to merge 1 commit into from

Conversation

datalek
Copy link
Contributor

@datalek datalek commented Jun 26, 2017

Pull Request Checklist

Purpose

Implements RequestBuilder and Response with akka-http

datalek
datalek commented Jun 26, 2017
View reviewed changes
...tte-akka-http-client/src/main/scala/silhouette/akka/http/client/AkkaHttpRequestBuilder.scala
copy(request = akkaHttpRequestPipeline.withQueryParams(params: _*).request)
}

override def withBody(body: Body): Self = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akkie We should change Body visibility I guess

[error] /Users/merle/works/scala/silhouette-akka-http/silhouette-akka-http-client/src/main/scala/silhouette/akka/http/client/AkkaHttpRequestBuilder.scala:61: method withBody in class AkkaHttpRequestBuilder references private[silhouette] class Body.
[error] Classes which cannot access Body may be unable to override withBody.
[error]   override def withBody(body: Body): Self = {
[error]                ^
[error] one error found

@datalek datalek changed the title Add implementation for RequestBuilder and Response [WIP] Add implementation for RequestBuilder and Response Jun 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@datalek