Support orders in the wallet #1823
Open
+2,897
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
approved these changes
Oct 8, 2024
OBorce
approved these changes
Oct 10, 2024
| /// The fields represent currencies and amounts to be exchanged and the trading pair can be deducted from it. | ||
| #[derive(Debug, Clone, PartialEq, Eq, Encode, Decode, serde::Serialize, serde::Deserialize)] | ||
| pub struct OrderData { | ||
| /// The key that can authorize conclusion of an order |
There was a problem hiding this comment.
I think it would be good to explain here what concluding an order will result into, for anyone reading this.
| @@ -2189,67 +2366,118 @@ fn group_preselected_inputs( | |||
| | TxOutput::CreateDelegationId(_, _) | |||
| | TxOutput::DelegateStaking(_, _) | |||
| | TxOutput::IssueFungibleToken(_) | |||
| | TxOutput::DataDeposit(_) => { | |||
| | TxOutput::DataDeposit(_) | |||
| | TxOutput::AnyoneCanTake(_) => { | |||
There was a problem hiding this comment.
Would CreateOrder be a better name than AnyoneCanTake?
| @@ -2132,7 +2308,8 @@ fn group_preselected_inputs( | |||
| chain_config: &ChainConfig, | |||
| block_height: BlockHeight, | |||
| dest_info_provider: Option<&dyn DestinationInfoProvider>, | |||
| ) -> Result<BTreeMap<currency_grouper::Currency, (Amount, Amount)>, WalletError> { | |||
| order_info: Option<&RpcOrderInfo>, | |||
There was a problem hiding this comment.
This should be a map <OrderId, &RpcOrderInfo> just in case to know that the order info is for the order from the inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.