Provide Amount
instead of OutputValue
to FillOrder
command
#1819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing
OutputValue
(i.e. currency + amount) to theAccountCommand::FillOrder
is redundant. Order can be filled with only particular currency defined on creation byOrderData
.As a result check for currency mismatch can be removed from
orders-accounting
, making it one rule less in the code.At the moment this change can be done without a fork because orders are not activated.