Added test for frame switching by an ID

minkphp · Feb 22, 2024 · 7055197 · 7055197
1 parent baa9e54
commit 7055197
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/tests/Basic/IFrameTest.php b/tests/Basic/IFrameTest.php
@@ -11,7 +11,7 @@ final class IFrameTest extends TestCase
      *
      * @dataProvider iFrameDataProvider
      */
-    public function testIFrame($iframeIdentifier): void
+    public function testIFrame($iframeIdentifier, $elementSelector, $elementContent): void
     {
         $this->getSession()->visit($this->pathTo('/iframe.html'));
         $webAssert = $this->getAssertSession();
@@ -21,8 +21,8 @@ public function testIFrame($iframeIdentifier): void
 
         $this->getSession()->switchToIFrame($iframeIdentifier);
 
-        $el = $webAssert->elementExists('css', '#text');
-        $this->assertSame('iFrame div text', $el->getText());
+        $el = $webAssert->elementExists('css', $elementSelector);
+        $this->assertSame($elementContent, $el->getText());
 
         $this->getSession()->switchToIFrame();
 
@@ -36,8 +36,9 @@ public function testIFrame($iframeIdentifier): void
     public function iFrameDataProvider()
     {
         return array(
-            'by name' => array('subframe'),
-            'by index' => array(1),
+            'by name' => array('subframe_by_name', '#text', 'iFrame div text'),
+            'by id' => array('subframe_by_id', '#foobar', 'Some accentués characters'),
+            'by index' => array(1, '#text', 'iFrame div text'),
         );
     }
 }
diff --git a/web-fixtures/iframe.html b/web-fixtures/iframe.html
@@ -4,7 +4,9 @@
 
 <iframe src="empty_textarea.html"></iframe>
 
-<iframe src="iframe_inner.html" name="subframe"></iframe>
+<iframe src="iframe_inner.html" name="subframe_by_name"></iframe>
+
+<iframe src="issue131.html" name="subframe_by_id"></iframe>
 
 <div id="text">
     Main window div text