PFS-130 upload moto card payments report (#16)

* PFS-143 Create back-end structure similar to finance-hub

* PFS-143 Create back-end structure similar to finance-hub

* PFS-143 Add test upload file code

* PFS-143 Update makefile and build yml

* PFS-143 Fix linting

* PFS-143 Add localstack for local bucket

* PFS-143 Upload file from form

* PFS-143 Fix linting

* PFS-143 Add SSE to upload

* PFS-143 Add success message, remove test upload type

* PFS-143 Migrate to aws-sdk-go-v2

* PFS-143 Attempt to fix blank endpoint

* PFS-143 Attempt to fix blank endpoint

* PFS-143 Undo previous change

* PFS-143 Move uploads to subfolder in bucket

* PFS-143 Move CSV header validation to back-end

* PFS-143 Add cypress test & api unit tests

* PFS-143 Create ADR

* PFS-143 Fix build

* PFS-143 Code cleanup, move upload type enum to shared

* PFS-143 Change case of upload type enum, undo SSE env var

* PFS-143 Fix cypress test

* PFS-143 Fix cypress test

* PFS-130 Change directory for testing

* PFS-130 Add s3 directory to enum

* PFS-130 Add MOTO card upload type headers

* PFS-130 Add MOTO card filename validation

* PFS-130 Remove validation for other reports

* PFS-130 Update SSE algorithm to use KMS

* PFS-130 Add error catching to upload type filename & add tests

docker-compose.yml

@@ -32,6 +32,7 @@ services:
       AWS_S3_ENDPOINT: http://localstack:4566
       AWS_ACCESS_KEY_ID: localstack
       AWS_SECRET_ACCESS_KEY: localstack
+      S3_ENCRYPTION_KEY: alias/aws/s3
     healthcheck:
       test: wget -O /dev/null -S 'http://localhost:8080/health-check' 2>&1 | grep 'HTTP/1.1 200 OK' || exit 1
       interval: 15s

finance-admin-api/api/upload.go

@@ -95,9 +95,10 @@ func (s *Server) upload(w http.ResponseWriter, r *http.Request) error {
 
 	_, err = s.awsClient.PutObject(ctx, &s3.PutObjectInput{
 		Bucket:               aws.String(os.Getenv("ASYNC_S3_BUCKET")),
-		Key:                  aws.String(fmt.Sprintf("%s/%s", "finance-admin", upload.Filename)),
+		Key:                  aws.String(fmt.Sprintf("%s/%s", upload.ReportUploadType.S3Directory(), upload.Filename)),
 		Body:                 bytes.NewReader(upload.File),
-		ServerSideEncryption: "AES256",
+		ServerSideEncryption: "aws:kms",
+		SSEKMSKeyId:          aws.String(os.Getenv("S3_ENCRYPTION_KEY")),
 	})
 
 	if err != nil {

finance-admin/internal/server/post_upload.go

@@ -7,6 +7,7 @@ import (
 	"github.com/opg-sirius-finance-admin/finance-admin/internal/model"
 	"github.com/opg-sirius-finance-admin/shared"
 	"net/http"
+	"strings"
 )
 
 type UploadFormHandler struct {
@@ -16,7 +17,7 @@ type UploadFormHandler struct {
 func (h *UploadFormHandler) render(v AppVars, w http.ResponseWriter, r *http.Request) error {
 	ctx := getContext(r)
 
-	reportUploadType := r.PostFormValue("reportUploadType")
+	reportUploadType := shared.ParseReportUploadType(r.PostFormValue("reportUploadType"))
 	uploadDate := r.PostFormValue("uploadDate")
 	email := r.PostFormValue("email")
 
@@ -27,7 +28,17 @@ func (h *UploadFormHandler) render(v AppVars, w http.ResponseWriter, r *http.Req
 	}
 	defer file.Close()
 
-	data, err := shared.NewUpload(shared.ParseReportUploadType(reportUploadType), uploadDate, email, file, handler.Filename)
+	expectedFilename, err := reportUploadType.Filename(uploadDate)
+	if err != nil {
+		return h.handleError(w, r, "Could not parse upload date", http.StatusBadRequest)
+	}
+
+	if handler.Filename != expectedFilename && expectedFilename != "" {
+		expectedFilename := strings.Replace(expectedFilename, ":", "/", -1)
+		return h.handleError(w, r, fmt.Sprintf("Filename should be named \"%s\"", expectedFilename), http.StatusBadRequest)
+	}
+
+	data, err := shared.NewUpload(reportUploadType, uploadDate, email, file, handler.Filename)
 	if err != nil {
 		return h.handleError(w, r, "Failed to read file", http.StatusBadRequest)
 	}

shared/upload_type.go

@@ -1,6 +1,10 @@
 package shared
 
-import "encoding/json"
+import (
+	"encoding/json"
+	"fmt"
+	"time"
+)
 
 var ReportUploadTypes = []ReportUploadType{
 	ReportTypeUploadPaymentsMOTOCard,
@@ -76,6 +80,8 @@ func (i ReportUploadType) Key() string {
 
 func (i ReportUploadType) CSVHeaders() []string {
 	switch i {
+	case ReportTypeUploadPaymentsMOTOCard:
+		return []string{"Ordercode", "Date", "Amount"}
 	case ReportTypeUploadDeputySchedule:
 		return []string{"Deputy number", "Deputy name", "Case number", "Client forename", "Client surname", "Do not invoice", "Total outstanding"}
 	case ReportTypeUploadDebtChase:
@@ -87,6 +93,28 @@ func (i ReportUploadType) CSVHeaders() []string {
 	}
 }
 
+func (i ReportUploadType) S3Directory() string {
+	switch i {
+	case ReportTypeUploadPaymentsMOTOCard:
+		return "moto-card-payments"
+	default:
+		return "finance-admin"
+	}
+}
+
+func (i ReportUploadType) Filename(date string) (string, error) {
+	switch i {
+	case ReportTypeUploadPaymentsMOTOCard:
+		parsedDate, err := time.Parse("2006-01-02", date)
+		if err != nil {
+			return "", err
+		}
+		return fmt.Sprintf("feemoto_%snormal.csv", parsedDate.Format("02:01:2006")), nil
+	default:
+		return "", nil
+	}
+}
+
 func ParseReportUploadType(s string) ReportUploadType {
 	value, ok := reportTypeUploadMap[s]
 	if !ok {

shared/upload_type_test.go

@@ -0,0 +1,49 @@
+package shared
+
+import (
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func TestReportUploadType_Filename(t *testing.T) {
+	tests := []struct {
+		name         string
+		uploadType   ReportUploadType
+		dateString   string
+		wantErr      bool
+		wantFilename string
+	}{
+		{
+			name:         "Non-moto card payments report type",
+			uploadType:   ReportTypeUploadDeputySchedule,
+			dateString:   "02/01/2020",
+			wantErr:      false,
+			wantFilename: "",
+		},
+		{
+			name:         "Moto card payments report type",
+			uploadType:   ReportTypeUploadPaymentsMOTOCard,
+			dateString:   "02/01/2020",
+			wantErr:      false,
+			wantFilename: "",
+		},
+		{
+			name:         "Invalid date",
+			uploadType:   ReportTypeUploadPaymentsMOTOCard,
+			dateString:   "hehe",
+			wantErr:      true,
+			wantFilename: "",
+		},
+	}
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			filename, err := test.uploadType.Filename(test.dateString)
+
+			assert.Equal(t, test.wantFilename, filename)
+
+			if test.wantErr {
+				assert.Error(t, err)
+			}
+		})
+	}
+}