Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addinng kms:DescribeKey for CICD member, https://github.com/hashicorp… #2356

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

harichintala1
Copy link
Contributor

Fix for DEFAULT KMS Key Error, Ref: hashicorp/terraform-provider-aws#3450

@harichintala1 harichintala1 requested a review from a team as a code owner September 29, 2022 20:15
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/modules/iam_baseline

*****************************

Running TFSEC in terraform/modules/iam_baseline
Excluding the following checks: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
  timings
  ──────────────────────────────────────────
  disk i/o             46.8µs
  parsing              1.130106ms
  adaptation           1.046305ms
  checks               120.493861ms
  total                122.717072ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     9
  files read           2

  results
  ──────────────────────────────────────────
  passed               5
  ignored              33
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/modules/iam_baseline

*****************************

Running Checkov in terraform/modules/iam_baseline
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 7, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `aws` plugin...
Installed `aws` (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.17.0)
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.1.0)
tflint will check the following folders:
terraform/modules/iam_baseline

*****************************

Running tflint in terraform/modules/iam_baseline
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Copy link
Contributor

@davidkelliott davidkelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harichintala1 changes to these files will be role out across all MP accounts, what issue are you having and we can have a look at finding a solution for you?

@harichintala1
Copy link
Contributor Author

Hi @harichintala1 changes to these files will be role out across all MP accounts, what issue are you having and we can have a look at finding a solution for you?

This is to overcome issue discussed here, hashicorp/terraform-provider-aws#3450

We have failing CircleCI pipeline here, https://app.circleci.com/pipelines/github/ministryofjustice/hmpps-digital-prison-reporting-glue-poc/43/workflows/4e0944c5-b655-4080-b967-e12367d34ec0/jobs/47

This will allow the cicd user to work with encrypted
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/modules/iam_baseline

*****************************

Running TFSEC in terraform/modules/iam_baseline
Excluding the following checks: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
  timings
  ──────────────────────────────────────────
  disk i/o             43.403µs
  parsing              1.20077ms
  adaptation           910.652µs
  checks               114.104687ms
  total                116.259512ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     7
  files read           2

  results
  ──────────────────────────────────────────
  passed               1
  ignored              39
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/modules/iam_baseline

*****************************

Running Checkov in terraform/modules/iam_baseline
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 5, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `aws` plugin...
Installed `aws` (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.17.0)
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.1.0)
tflint will check the following folders:
terraform/modules/iam_baseline

*****************************

Running tflint in terraform/modules/iam_baseline
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@davidkelliott davidkelliott merged commit 75e5e2c into main Sep 30, 2022
@davidkelliott davidkelliott deleted the DPR-81 branch September 30, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants