Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story: [CCLS 2191] Use common auth starter #12

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

farrell-m
Copy link
Contributor

@farrell-m farrell-m commented Jun 3, 2024

  • Use common auth starter
    • Added application properties to configure auth
  • Added 403 Forbidden to endpoints in OpenAPI spec
  • Added configuration to handle authentication during testing

DRAFT: Common library version needs to be removed (to use version provided by SB plugin) when Auth Starter PR is merged.

@farrell-m farrell-m marked this pull request as ready for review June 6, 2024 16:08
@PhilDigitalJustice
Copy link
Contributor

Can we just update the readme, stating it uses the common library

Copy link
Contributor

@PhilDigitalJustice PhilDigitalJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@PhilDigitalJustice PhilDigitalJustice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farrell-m farrell-m merged commit 9085b01 into main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants