Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Address transaction type todo #7571

Merged
merged 2 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions app/helpers/user_transactions_helper.rb

This file was deleted.

12 changes: 0 additions & 12 deletions config/locales/cy/transaction_types.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,6 @@
cy:
transaction_types:
names:
citizens:
benefits: stifeneB
child_care: stnemyap eracdlihC
excluded_benefits: stifeneb dedragersiD
friends_or_family: ylimaf ro sdneirf morf pleh laicnaniF
legal_aid: esac lanimirc a ni dia lagel sdrawot stnemyaP
maintenance_in: rentrap remrof a morf stnemyap ecnanetniaM
maintenance_out: rentrap remrof a ot stnemyap ecnanetniaM
pension: noisneP
property_or_lodger: regdol ro ytreporp a morf emocnI
rent_or_mortgage: stnemyap gnisuoH
salary: segaw ro yralaS
providers:
benefits: stifeneB
child_care: stnemyap eracdlihC
Expand Down
15 changes: 0 additions & 15 deletions config/locales/en/transaction_types.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,6 @@
en:
transaction_types:
names:
# TODO: remove this as we don't actually show transaction categories to citizens anymore, however these categories are still
# being used in a few places, and have tests and helper methods which will also need to be updated/removed
citizens:
benefits: Benefits, charitable or government payments
child_care: Childcare payments
excluded_benefits: Disregarded benefits
friends_or_family: Financial help from friends or family
housing_benefit: Housing Benefit
legal_aid: Payments towards legal aid in a criminal case
maintenance_in: Maintenance payments from a former partner
maintenance_out: Maintenance payments to a former partner
pension: Pension
property_or_lodger: Income from a property or lodger
rent_or_mortgage: Housing payments
salary: Salary or wages
providers:
benefits: Benefits, charitable or government payments
child_care: Childcare payments
Expand Down
73 changes: 0 additions & 73 deletions spec/helpers/user_transactions_helper_spec.rb

This file was deleted.

Loading