Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove PLF routing TODOs #7569

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

colinbruce
Copy link
Contributor

What

These were added while the individual pages were implemented and can now be removed

Remove the TODO and add the correct path to the expectations

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the chore/remove-plf-routing-todos branch from 11c4c1a to d390dd0 Compare January 10, 2025 10:47
These were added while the individual pages were implemented and
can now be removed
@colinbruce colinbruce force-pushed the chore/remove-plf-routing-todos branch from d390dd0 to c6cd3ee Compare January 10, 2025 10:49
@colinbruce colinbruce added the ready for review Please review label Jan 10, 2025
@colinbruce colinbruce marked this pull request as ready for review January 10, 2025 11:02
@colinbruce colinbruce requested a review from a team as a code owner January 10, 2025 11:02
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 LGTM

@colinbruce colinbruce merged commit eeb2237 into main Jan 13, 2025
15 checks passed
@colinbruce colinbruce deleted the chore/remove-plf-routing-todos branch January 13, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants