Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap 5419 decommission ccms pda #7494

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

kmahern
Copy link
Contributor

@kmahern kmahern commented Dec 2, 2024

What

Link to story

Remove all references to CCMS PROVIDER_DETAILS_URL environment variable.
Remove CCMS provider_details_retriever and provider_details_creator code.
Remove code that compares new PDA with CCMS provider details.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Copy link

sonarqubecloud bot commented Dec 2, 2024

@kmahern kmahern added the ready for review Please review label Dec 2, 2024
@kmahern kmahern marked this pull request as ready for review December 2, 2024 09:32
@kmahern kmahern requested a review from a team as a code owner December 2, 2024 09:32
@kmahern kmahern added the do not merge This PR should not be merged label Dec 3, 2024
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

PS: may want to hold off over concerns you raised to peter about new PDA and providers in two firms.

@jsugarman jsugarman added approved Approved by code reviewers and removed ready for review Please review labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers do not merge This PR should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants