Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test branch name change impact for 5524 format error handling #7490

Closed
wants to merge 3 commits into from
Closed

Test branch name change impact for 5524 format error handling #7490

wants to merge 3 commits into from

Conversation

jsugarman
Copy link
Contributor

@jsugarman jsugarman commented Nov 28, 2024 •
edited
Loading

What

Other 5524 branches deployment fails with ERR_NAME_NOT_RESOLVED so want to rule out deployment issues

Screenshot 2024-11-28 at 17 38 40

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@jsugarman
AP-5524 extension: handle invalid format request with 404
7918ba4 
Scripted probing attacks may use format modifiers on their
request. This handles them with a 404. The advatage
of this to not give the attacker info on what is a server
error and to not raise this an actual error in the code base.

We have an alert for 404s (exceeding 100) in a 24 hour period
which will alert us to a serious probing attack in any event.
@jsugarman
remove respond_to test
605c8a1
@jsugarman
readd respond_to test
44bcc03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jsugarman jsugarman closed this Nov 28, 2024
@jsugarman jsugarman deleted the jsugarman/change-of-branch-name branch November 28, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jsugarman