Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5368 cash income and outgoings bug #7472

Closed
wants to merge 0 commits into from
Closed

Conversation

RoseSAK
Copy link
Contributor

@RoseSAK RoseSAK commented Nov 25, 2024

What

Link to story

Ensure none_selected value is retained when there is an error

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@RoseSAK RoseSAK marked this pull request as ready for review November 25, 2024 17:07
@RoseSAK RoseSAK requested a review from a team as a code owner November 25, 2024 17:07
@RoseSAK RoseSAK added the ready for review Please review label Nov 25, 2024
@RoseSAK RoseSAK closed this Nov 26, 2024
@RoseSAK RoseSAK force-pushed the ap-5368-cash-income-error branch from d7e3425 to 9cf2c13 Compare November 26, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants